This repository was archived by the owner on Jul 18, 2025. It is now read-only.
Fix broken IsVTXDisabled detection on AMD CPU #4679
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VMX is in FeatureNames, but SVM is in ExtraFeatureNames
This meant that detection always failed for SVM (AMD)
Thanks to user @hilbertxia
Description
The new library approach to cpuid introduced in 5a8ce1a was broken on AMD CPU (SVM).
Unfortunately it also disabled all tests that were in the previous file-based version 850e264
Related issue(s)
Closes #4669