This repository was archived by the owner on Jul 18, 2025. It is now read-only.
Allow creating vm with vapp options #4598
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergej Nikolaev <kinolaev@gmail.com>
|
Please sign your commits following these rules: $ git clone -b "vsphere-vapp-options" git@github.com:kinolaev/machine.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
kinolaev
force-pushed
the
vsphere-vapp-options
branch
from
e0093f5 to
0b5a5bd
Compare
3 tasks
|
I don't understand why travis ci build failed, same commands works well on my machine, I think it's not related to my PR. |
|
Hello @shin-, can you please review this PR? Automatic static IP allocation is very useful feature for vSphere users! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows users to pass vApp Options when creating VM in VMWare vCenter. Through vApp Options vCenter can pass static IP address from configured network protocol profile, so users don't need to install dhcp server.
Related issue(s)
rancher/rancher#15817
rancher#13