This repository was archived by the owner on Jul 18, 2025. It is now read-only.
[WIP] Switch Dockerfile to golang:alpine as the base image #4422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump Golang version to 1.9.4 and pin Alpine to 3.7. Signed-off-by: Ivan Markin <sw@nogoegst.net>
unkaktus
force-pushed
the
alpine-dockerfile
branch
from
9e95689 to
39460b8
Compare
|
Oh no, I completely forgot that Golang race detector requires glibc and doesn't work on Alpine Linux (golang/go#14481). I'll try to fix this somehow. |
|
please fix it, really painful can't use race in alpine |
|
sorry @tlightsky, what is painful? |
|
the fact that docker:alpine image can't use race :( |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces disk footprint from ~730MB to ~270MB for base image, speeds up package installation and leaves no package manager cache to be removed.
Golang version was bumped to 1.9.4 and Alpine image pinned to 3.7.
Also there is a minor syntax fix.