This repository was archived by the owner on Jul 18, 2025. It is now read-only.
[IMP] Add EC2 instance tenancy #4356
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please sign your commits following these rules: $ git clone -b "feature/ec2-host-type" git@github.com:lasley/machine.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
lasley
force-pushed
the
feature/ec2-host-type
branch
from
0a2a1d3 to
8002b84
Compare
lasley
force-pushed
the
feature/ec2-host-type
branch
from
8002b84 to
22a769a
Compare
lasley
force-pushed
the
feature/ec2-host-type
branch
from
22a769a to
3b28cdf
Compare
* Add option to control EC2 instance placement tenancy (default, dedicated, host) Signed-off-by: Dave Lasley <dave@laslabs.com>
lasley
force-pushed
the
feature/ec2-host-type
branch
from
3b28cdf to
c488220
Compare
|
@lasley You need to amend the commit so that the code is formatted according to the project rules. See https://github.com/docker/machine/blob/master/CONTRIBUTING.md#tests-and-validation |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I admittedly haven't compiled or tested this yet, but the theory seems sound. Is this something you would accept once tested? If so, is there anything I'm missing from a quick glance?