fix(permissions): split comma-separated paths in --ignore-read#35661
Open
chatman-media wants to merge 1 commit into
Open
fix(permissions): split comma-separated paths in --ignore-read#35661chatman-media wants to merge 1 commit into
chatman-media wants to merge 1 commit into
Conversation
The help text for --ignore-read advertises comma-separated paths just like --allow-read and --deny-read (--ignore-read="/etc,/var/log.txt"), but the parse site just did a plain .collect() with no comma-splitting, so the whole string got stored as one literal entry that never matches a real path. --ignore-env handles this correctly via use_value_delimiter, which is what tipped me off that --ignore-read was the odd one out rather than this being intentional. Added a test covering the comma-separated case.
Deno Individual Contributor License AgreementThe following contributors need to sign the CLA before this PR can be merged: Click here to review and sign the CLA | Re-run CLA check This is an automated message from CLA Assistant |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The help text for
--ignore-readadvertises comma-separated paths the same way--allow-read/--deny-readdo (--ignore-read="/etc,/var/log.txt"), but the parse site just did a plain.collect()with no comma-splitting, so a comma-separated value got stored as one literal string that never matches a real path — the ignore rule silently does nothing.--ignore-envhandles this correctly viause_value_delimiter, which is what made--ignore-readstand out as the inconsistent one rather than this being intentional.Fixed it to go through
flat_escape_split_commas, same as the adjacentallow-read/deny-readblocks. Added a test covering the comma-separated case.