Skip to content

refactor: support row/bucket shuffle for aggregation #19155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
dqhl76 wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

refactor: support row/bucket shuffle for aggregation #19155

dqhl76 wants to merge 9 commits into from

Conversation

@dqhl76
Copy link
Collaborator

@dqhl76 dqhl76 commented Dec 25, 2025 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

I'm breaking this PR down into smaller ones.
This PR currently serves as an integration test for the overall functionality.

image image

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable
@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Dec 25, 2025
This was referenced Dec 25, 2025
Merged
Draft
@dqhl76
refactor: support row/bucket shuffle for aggregation
85cea16 
refactor: refactor spiller

row shuffle spill

tmp save

clean

pass bucket partial force spill

pass tpch

basic pass

feat: add support for partitioned aggregate serialization and deserialization

save

remove unused activate_worker

refactor: also add stats for final aggregate

feat: implement configurable aggregate shuffle mode

refactor: add basic bucket level shuffled agg

refactor: remove legacy final agg

feat: refactor aggregate function in build_aggregate to make it clear
@dqhl76
fmt
672b885
@dqhl76
enable_experiment_aggregate = 1
fc733c1
@dqhl76
license check
df270a0
@dqhl76
make clippy happy
40737d1
@dqhl76
make clippy happy
70710f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-refactor this PR changes the code base without new features or bugfix

1 participant

@dqhl76