[Clang] Fix parsing of pack-index-specifier with template-id pattern #3
+95
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
ParseOptionalCXXScopeSpecifieronly handled pack-index-specifiers where the pattern was a simple identifier (e.g.,T...[0]::). This patch adds support fortemplate-idpatterns (e.g.,Foo<T>...[0]::).The fix involves two parts:
ParsePackIndexingTypeto handletok::annot_template_idin addition totok::identifier.ParseOptionalCXXScopeSpecifierforannot_template_idfollowed by... [ constant-expression ].This fixes code like:
which previously failed to parse.