Skip to content

Conversation

@kidkidkid
Copy link
Collaborator

What type of PR is this?

Check the PR title.

  • This PR title match the format: [<type>][<scope>]: <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 97.01493% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
backend/modules/observability/infra/rpc/tag/tag.go 0.00% 1 Missing ⚠️
...ckend/modules/observability/infra/tenant/tenant.go 0.00% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #276      +/-   ##
==========================================
+ Coverage   69.61%   69.63%   +0.01%     
==========================================
  Files         616      617       +1     
  Lines       58272    58287      +15     
==========================================
+ Hits        40567    40587      +20     
+ Misses      14722    14720       -2     
+ Partials     2983     2980       -3     
Flag Coverage Δ
unittests 69.63% <97.01%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
backend/modules/observability/application/trace.go 72.75% <100.00%> (+0.36%) ⬆️
...es/observability/domain/component/tenant/tenant.go 100.00% <100.00%> (ø)
...bservability/domain/trace/service/trace_service.go 83.81% <100.00%> (ø)
backend/modules/observability/infra/rpc/tag/tag.go 0.00% <0.00%> (ø)
...ckend/modules/observability/infra/tenant/tenant.go 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 333e255...7d86d04. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@kidkidkid kidkidkid force-pushed the feat/get_trace_refactor branch from 58e7e16 to 7d5d29e Compare October 31, 2025 10:01
Copy link
Collaborator

@CozeLoop CozeLoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aime Review: Identified 1 Must-Fix and several Should-Fix/Suggestions in concurrency and configuration handling. Please see inline comments for details.

@kidkidkid kidkidkid force-pushed the feat/get_trace_refactor branch 6 times, most recently from 919e929 to 195a25c Compare December 19, 2025 07:06
@kidkidkid kidkidkid force-pushed the feat/get_trace_refactor branch from 195a25c to 0e6707f Compare December 24, 2025 09:21
@kidkidkid kidkidkid force-pushed the feat/get_trace_refactor branch from 66a92a1 to 195a13c Compare December 31, 2025 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants