mantle/aws: simplify force upload handling of s3 objects #4243
Conversation
![gemini-code-assist[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request simplifies the force upload logic by moving the S3 object deletion out of API.RemoveImage and into the ore aws upload command. This is a good step towards better separation of concerns. My review identifies a regression where error handling for non-existent S3 objects was lost in the move, which could cause the command to fail unnecessarily. I've provided a suggestion to restore the correct behavior.
dustymabe
force-pushed
the
dusty-aws-upload-simplify
branch
from
d9a91e8 to
02f5631
Compare
This will make it so we don't have to conditionalize the function call to API.RemoveImage based on if we are uploading WinLI images or not. This is prep for more simplification in the future.
dustymabe
force-pushed
the
dusty-aws-upload-simplify
branch
from
02f5631 to
991bd6f
Compare
|
Not sure of the prow CI failure, but it's definitely not related to this PR: /override ci/prow/rhcos |
|
@dustymabe: Overrode contexts on behalf of dustymabe: ci/prow/rhcos In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This will make it so we don't have to conditionalize the function call to API.RemoveImage based on if we are uploading WinLI images or not.
This is prep for more simplification in the future.