-
Notifications
You must be signed in to change notification settings - Fork 382
Proofread Conan1.0.rst #722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Rami! A couple of observations!
I'm very very happy to start seeing reviews ;)
conan1.0.rst
Outdated
| - ``CMake`` helper only allows now (from conan 0.29). the ``CMake(self)`` syntax | ||
| - :command:`conan package_files` command was replaced in conan 0.28 by :command:`conan export-pkg` command. | ||
| - ``self.conanfile_directory`` has been removed. Instead, use ``self.source_folder``, ``self.build_folder``, etc. | ||
| - ``self.cpp_info``, ``self.env_info`` and ``self.user_info`` scope has been reduced to only include the ``package_info()`` method |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The real sense of the sentence is something like "self.cpp_info, self.env_info and self.user_info now exist only inside the package_info() method.``
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something like would be better:
``self.cpp_info``, ``self.env_info`` and ``self.user_info`` scope has been reduced to the ``package_info()`` method exclusively.
conan1.0.rst
Outdated
| gcc and clang compilers have modified their versioning approach, from gcc > 5 and clang > 4, | ||
| the minors are really bugfixes, and then they have binary compatibility. To adapt to this, | ||
| conan now includes major version in the *settings.yml* default settings file: | ||
| The GCC and Clang compilers have modified their versioning approach. From GCC version 5 and above and Clang versiom 4 and above, minor versions are really bug fixes, and then, they have binary compatibility. To adapt to this, Conan now includes a major version in the *settings.yml* default settings file: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and Clang versiom 4 and
No description provided.