Updated virtualrunenv generator and some fixes #677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
memsharded
requested changes
Jun 8, 2018
Member
memsharded
left a comment
memsharded
left a comment
There was a problem hiding this comment.
I am not suggesting this. The whole package_info() defining PATH, LD_LIBRARY_PATH, etc, is wrong. It is not the recommended way to do this, but to use a virtualrunenv. I am suggesting change how things are explained.
memsharded
approved these changes
Jun 11, 2018
|
|
||
| $ conan install . | ||
| $ source activate_run | ||
| $ toolA --someparams |
Member
There was a problem hiding this comment.
I think the security restriction of OSX is also active here, and it might be ncessary to do the DYLD_LIBRARY_PATH = in the command line.
memsharded
pushed a commit
that referenced
this pull request
Jun 27, 2018
* updated virtualrunenv generator * rewrite using virtualrunenv and runenvironment helper * fix * mac fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #676