Fix CMake macro packaged in a dependency example #4156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbrilRBS
approved these changes
Jul 4, 2025
czoido
added a commit
that referenced
this pull request
Jul 16, 2025
* add CMakeDeps (#4156) * Use newer versions for zlib and cmake in docs (#4157) * use newest versions for zlib and cmake * revert some changes * Improve context for platform_tool_requires (#4162) * Add explanation for platform_tool_requires context * Add same warning to replace_tool_requires * Add Essentials to seealso training sections (#4164) * seealso for JFrog Academy * Add knowledge entry * Wording * Apply suggestion from @AbrilRBS * Review, wording from blogpost * toctree before training note * missing workspace super-install changes (#4166) --------- Co-authored-by: Abril Rincón Blanco <5364255+AbrilRBS@users.noreply.github.com> Co-authored-by: James <james@conan.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The app needs CMakeDeps to work, otherwise it won't find the macro.