Skip to content

Update deps_and_cli.adoc #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update deps_and_cli.adoc #630

wants to merge 1 commit into from

Conversation

Crowbrammer
Copy link

Disambiguate the Deps and CLI guide from the reference.

  • Have you read the guidelines for contributing?
  • Have you signed the Clojure Contributor Agreement?
  • Have you verified your asciidoc markup is correct?
@Crowbrammer
Update deps_and_cli.adoc
97c7922 
Disambiguate the Deps and CLI guide from the reference.
@puredanger
Copy link
Member

I don’t think this is needed - the reference is already mentioned and linked at the end of the intro
@puredanger puredanger closed this Jan 8, 2023
@Crowbrammer
Copy link
Author

Crowbrammer commented Jan 8, 2023 •
edited
Loading

There are two pull requests, one for the guide, and one for the reference (this PR).

The guide has the link at the end of the intro. The reference does not.

The fact that you're confusing these two proves that disambiguation is needed.

Please reconsider :| That said, I've used your guide and reference a lot over the years, and it's very helpful - so thanks, regardless of whatever you do here.
@puredanger
Copy link
Member

Sorry, this comment was on the wrong PR (was reviewing from my phone). I've added a list of relevant links to the reference intro.
@Crowbrammer
Copy link
Author

That works! Thank you!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@Crowbrammer @puredanger