Skip to content

Installation in one command #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Installation in one command #446

wants to merge 2 commits into from

Conversation

audriu
Copy link
Contributor

@audriu audriu commented Jan 28, 2020

Making installation a little bit easier for new people to come and be more encouraged.

  • Have you read the guidelines for contributing?
  • Have you signed the Clojure Contributor Agreement?
  • Have you verified your asciidoc markup is correct?
Making installation a little bit easier for new people to come and be more encouraged.
@audriu
Copy link
Contributor Author

audriu commented Jan 28, 2020

Also - I think that installer could use logic like https://sdkman.io/install (separate commit) and install only in home dir. so people could use this installer in environments without sudo. What you think about it?

@audriu audriu requested a review from puredanger January 30, 2020 08:21
@SevereOverfl0w
Copy link
Contributor

I'd prefer this wasn't recommended due to the many problems with piping directly into bash.

https://www.idontplaydarts.com/2016/04/detecting-curl-pipe-bash-server-side/
https://www.seancassidy.me/dont-pipe-to-your-shell.html

@audriu
Copy link
Contributor Author

audriu commented Jan 31, 2020

I'd prefer this wasn't recommended due to the many problems with piping directly into bash.

https://www.idontplaydarts.com/2016/04/detecting-curl-pipe-bash-server-side/
https://www.seancassidy.me/dont-pipe-to-your-shell.html

but both of these assume malicious server. Which Clojure-site is not. One on sites even uses words like "stupid" and "dumb" - how professional...

@puredanger
Copy link
Member

Assuming you haven't been MITM'ed and you're actually talking to the server....

@audriu
Copy link
Contributor Author

audriu commented Feb 1, 2020

IMHO if you have MITM - you are already hacked...

@SevereOverfl0w
Copy link
Contributor

The Sean Cassidy article actually mentions other issues with piping, those related to having an unstable WiFi connection.

@audriu audriu closed this Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants