Skip to content

java_interop: how to attach java annotations #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2019
Merged

java_interop: how to attach java annotations #390

merged 1 commit into from
Jun 6, 2019

Conversation

holyjak
Copy link
Contributor

@holyjak holyjak commented May 29, 2019

  • Have you read the guidelines for contributing?
  • Have you signed the Clojure Contributor Agreement?
  • Have you verified your asciidoc markup is correct?
@puredanger
Copy link
Member

There is an example of annotations at https://clojure.org/reference/datatypes#_java_annotation_support. Would prefer to add a pointer there from java_interop (and maybe compilation) pages. Definitely don't want to just point into the middle of a test, so that's a no go.
@holyjak
Copy link
Contributor Author

holyjak commented May 31, 2019

Thank you for the pointer! Fixed.
@holyjak
Copy link
Contributor Author

holyjak commented Jun 6, 2019

@puredanger Is the PR OK now? Thank you!
@puredanger
Copy link
Member

the links here should be xrefs...

<<metadata#,metadata> and <<datatypes#_java_annotation_support,datatypes reference>>
@puredanger puredanger removed the blocked label Jun 6, 2019
@puredanger puredanger merged commit 25bc588 into clojure:master Jun 6, 2019
@holyjak
Copy link
Contributor Author

holyjak commented Jun 7, 2019

Thank you, @puredanger ! I am sorry I haven't managed to fix the links in time.
@holyjak holyjak deleted the patch-4 branch June 7, 2019 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@holyjak @puredanger