Skip to content

Fix integration with platformio #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2022
Merged

Fix integration with platformio #96

merged 1 commit into from
Sep 26, 2022

Conversation

gldhnchn
Copy link
Contributor

Add dependencies to library.json. This will maybe solve issue #90.
@tobozo
Copy link
Collaborator

tobozo commented Sep 26, 2022

@gldhnchn thanks !

Can you specify what OS/pio version this was failing on so I can extend the CI tests?
@tobozo tobozo merged commit cb627b7 into chrisjoyce911:master Sep 26, 2022
@gldhnchn
Copy link
Contributor Author

Yes, of course. But I guess this would have failed on every OS with platformio. Am I wrong?

$ platformio --version
PlatformIO Core, version 6.1.4
$ lsb_release -a
LSB Version:	core-11.1.0ubuntu4-noarch:printing-11.1.0ubuntu4-noarch:security-11.1.0ubuntu4-noarch
Distributor ID:	Ubuntu
Description:	Ubuntu 22.04.1 LTS
Release:	22.04
Codename:	jammy
@tobozo
Copy link
Collaborator

tobozo commented Sep 26, 2022

looks like both the workflow and the platformio.ini need an update.

I'll look into that before producing a new release.

thanks for your precious feedback ! 👍
@tobozo
Copy link
Collaborator

tobozo commented Sep 26, 2022

the CI could reproduce the error, and a fix is ready, new release coming soon :-)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@gldhnchn @tobozo