Prioritize SNAP_CURRENT in containerd paths - #4710
Merged
Merged
Conversation
bschimke95
approved these changes
Oct 22, 2024
bschimke95
left a comment
bschimke95
left a comment
Contributor
There was a problem hiding this comment.
LGTM, we can merge this after 1.31 branch out
berkayoz
pushed a commit
that referenced
this pull request
Oct 24, 2024
berkayoz
pushed a commit
that referenced
this pull request
Oct 24, 2024
berkayoz
pushed a commit
that referenced
this pull request
Oct 24, 2024
berkayoz
pushed a commit
that referenced
this pull request
Oct 24, 2024
berkayoz
pushed a commit
that referenced
this pull request
Oct 24, 2024
berkayoz
pushed a commit
that referenced
this pull request
Oct 24, 2024
berkayoz
pushed a commit
that referenced
this pull request
Oct 24, 2024
berkayoz
pushed a commit
that referenced
this pull request
Oct 24, 2024
This was referenced Oct 24, 2024
bschimke95
pushed a commit
that referenced
this pull request
Oct 24, 2024
bschimke95
pushed a commit
that referenced
this pull request
Oct 24, 2024
bschimke95
pushed a commit
that referenced
this pull request
Oct 24, 2024
bschimke95
pushed a commit
that referenced
this pull request
Oct 24, 2024
bschimke95
pushed a commit
that referenced
this pull request
Oct 24, 2024
bschimke95
pushed a commit
that referenced
this pull request
Oct 24, 2024
bschimke95
pushed a commit
that referenced
this pull request
Oct 24, 2024
berkayoz
pushed a commit
that referenced
this pull request
Oct 25, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wrong priority in path leads to issues with containerd-shim binary trying to be called from a previous revision that is not installed anymore. Prioritizing $SNAP_CURRENT paths makes sure this path always exists and points to the latest binary.
Fixes #4691