[Backport 1.28] k8s-dqlite watcher query timeout backport - #4651
Merged
Conversation
louiseschmidtgen
changed the title
louiseschmidtgen
force-pushed
the
backport-1.28-watch-timeout
branch
from
September 3, 2024 09:34
31fadaa to
e8656d7
Compare
bschimke95
approved these changes
Sep 3, 2024
bschimke95
left a comment
bschimke95
left a comment
Contributor
There was a problem hiding this comment.
LGTM, once CI passes (failure seems to be unrelated to the change)
louiseschmidtgen
force-pushed
the
backport-1.28-watch-timeout
branch
from
September 4, 2024 07:39
e139ec5 to
d2a3d6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backports watcher query timeout in k8s-dqlite: canonical/k8s-dqlite#161
The PR adds a timeout on long running after queries in k8s-dqlite which are part of the watcher's poll loop.
The timeout is configurable using the
watch-query-timeoutflag.Context
This PR addresses issues raised in microk8s where after the leader node is removed from the cluster the remaining nodes also go into
NotReadystate for ~20 minutes. This timeout helps the responsiveness of the cluster after loosing its leader.