chore: Remove minio addon - #378
Merged
Merged
Conversation
HomayoonAlimohammadi
marked this pull request as ready for review
December 15, 2025 15:36
berkayoz
suggested changes
Dec 16, 2025
berkayoz
left a comment
Contributor
There was a problem hiding this comment.
We should turn the enable command into a no-op / deprecation(removal) warning and keep the disable script as is. We should let users disable the addon. We can drop testing for it as well.
HomayoonAlimohammadi
force-pushed
the
chore/remove-minio
branch
from
December 16, 2025 11:23
3ae0eda to
2448d33
Compare
Contributor
Author
|
Great point, thanks for the review @berkayoz! I've added a deprecation note to the enable script and addon description as well. |
Signed-off-by: Homayoon (Hue) Alimohammadi <homayoon.alimohammadi@canonical.com>
HomayoonAlimohammadi
force-pushed
the
chore/remove-minio
branch
from
December 16, 2025 14:20
6dd58a6 to
cb6542c
Compare
berkayoz
approved these changes
Dec 17, 2025
berkayoz
left a comment
Contributor
There was a problem hiding this comment.
LGTM, have you tested the disabling under deprecation?
Contributor
Author
|
@berkayoz yes, here's the result: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR removes minio addon since it's entered maintenance mode.