Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix incorrect image dimensions
  • Loading branch information
cabanier authored and toji committed Dec 1, 2021
commit 28f3c71549df007cb9b5624b9f4fccc718bcbbbc
14 changes: 7 additions & 7 deletions webxrlayers-1.bs
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@ XRProjectionLayer {#xrprojectionlayertype}
An {{XRProjectionLayer}} is a layer that fills the entire view of the observer.
Projection layers should be refreshed close to the device's native frame rate.

<img alt="representation of a projection layer" src="images/projection-layer.jpg" style="width:50%; border-style: ridge;"/>
<img alt="representation of a projection layer" src="images/projection-layer.jpg" style="width:50%; height: 50%; border-style: ridge;"/>

<pre class="idl">
[Exposed=Window] interface XRProjectionLayer : XRCompositionLayer {
Expand Down Expand Up @@ -477,7 +477,7 @@ Only the front of the layer MUST be visible; the back face MUST not be drawn by
A XRQuadLayer has no thicknes. It is a two-dimensional object positioned and oriented in 3D space. The position
of a quad refers to the center of the quad.

<img alt="representation of a quad layer" src="images/quad-layer.jpg" style="width:50%; border-style: ridge;"/>
<img alt="representation of a quad layer" src="images/quad-layer.jpg" style="width:50%; height: 50%; border-style: ridge;"/>

<pre class="idl">
[Exposed=Window] interface XRQuadLayer : XRCompositionLayer {
Expand Down Expand Up @@ -523,7 +523,7 @@ XRCylinderLayer {#xrcylinderayertype}
An {{XRCylinderLayer}} renders a layer that takes up a curved rectangular space in the virtual environment.
Only the front of the layer MUST be visible; the back face MUST not be drawn by the [=XR Compositor=].

<img alt="representation of a cylinder layer" src="images/cylinder-layer.png" style="width:50%; border-style: ridge;"/>
<img alt="representation of a cylinder layer" src="images/cylinder-layer.png" style="width:50%; height: 50%; border-style: ridge;"/>

A XRCylinderLayer has no thicknes. It is a two-dimensional object positioned and oriented in 3D space. The position
of the cylinder refers to the center of the quad.
Expand Down Expand Up @@ -554,7 +554,7 @@ It grows symmetrically around the 0 angle.

The <dfn attribute for="XRCylinderLayer">aspectRatio</dfn> attribute controls the ratio of the visible cylinder section. It is the ratio of the width of the visible section of the cylinder divided by its height. The width is calculated by multiplying the {{XRCylinderLayer/radius}} with the {{XRCylinderLayer/centralAngle}}.

<img alt="description of the parameters of a cylinder layer"src="images/cylinder_layer_params.png" style="width:80%"/>
<img alt="description of the parameters of a cylinder layer"src="images/cylinder_layer_params.png" style="width: 80%; height: 80%;"/>

<div class="algorithm" data-algorithm="initCylinderLayerAlgo">
When <dfn lt="initialize a cylinder layer">initializing an {{XRCylinderLayer}} |layer| with an {{XRCylinderLayerInit}} |init|</dfn>, the user agent MUST run the following steps:
Expand All @@ -579,7 +579,7 @@ XREquirectLayer {#xrequirectlayertype}
---------------
An {{XREquirectLayer}} renders a layer where the [=XR Compositor=] MUST map an equirectangular coded data onto the inside of a sphere.

<img alt="representation of an equirect layer" src="images/equirect-layer.png" style="width:50%; border-style: ridge;"/>
<img alt="representation of an equirect layer" src="images/equirect-layer.png" style="width:50%; height: 50%; border-style: ridge;"/>

ISSUE: this section needs clarification

Expand Down Expand Up @@ -615,7 +615,7 @@ a value higher than 2π will set it to 2π.
Setting {{XREquirectLayer/upperVerticalAngle}} or {{XREquirectLayer/lowerVerticalAngle}} to a value less than -π/2 will set it
to -π/2 and setting it to a value higher than π/2 will set it to π/2.

<img alt="description of the parameters of an equirect layer" src="images/equirect.png" style="width:50%"/>
<img alt="description of the parameters of an equirect layer" src="images/equirect.png" style="width:50%; height: 50%;"/>

When assigning an {{XRSpace}} to the {{XREquirectLayer/space}} attribute, first run the following steps.

Expand Down Expand Up @@ -652,7 +652,7 @@ XRCubeLayer {#xcubelayertype}
-----------
A {{XRCubeLayer}} renders a layer where the [=XR Compositor=] renders directly from a cubemap.

<img alt="representation of a cube layer" src="images/cube-layer.jpg" style="width:50%; border-style: ridge;"/>
<img alt="representation of a cube layer" src="images/cube-layer.jpg" style="width:50%; height: 50%; border-style: ridge;"/>

ISSUE: this section needs clarification

Expand Down