Add support for GCS #145
Merged
Add support for GCS #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanpark-dandy
changed the title
Closed
This adds support for Google Cloud Storage via gsutil or gcloud storage CLI. Features: - Auto-detection of gcloud vs gsutil CLI - Support for BUILDKITE_PLUGIN_GCS_CACHE_BUCKET configuration - Support for BUILDKITE_PLUGIN_GCS_CACHE_PREFIX for key prefixing - Support for BUILDKITE_PLUGIN_GCS_CACHE_QUIET for silent operation - Support for BUILDKITE_PLUGIN_GCS_CACHE_CLI to force specific CLI Addresses reviewer feedback from buildkite-plugins#138
juanpark-dandy
force-pushed
the
master
branch
from
c25eee3 to
fc8f593
Compare
Contributor
Author
|
I tested this in my own private repos and it seems to be working! Will eagerly wait for reviewer feedback so we can get this merge ready and get this functionality in for others :) |
juanpark-dandy
commented
Jan 17, 2026
Contributor
|
@juanpark-dandy thanks for the PR! Currently there is just one failing test; ✗ Folder exists and can be restored after save
--
(from function `assert_success' in file /usr/lib/bats/bats-assert/src/assert_success.bash, line 42,
in test file tests/cache_gcs.bats, line 160)
`assert_success' failed
-- command failed --
status : 1
output (14 lines):
ln: unrecognized option: d
BusyBox v1.31.1 () multi-call binary.
Usage: ln [OPTIONS] TARGET... LINK\|DIR
Create a link LINK or DIR/TARGET to the specified TARGET(s)
-s Make symlinks instead of hardlinks
-f Remove existing destinations
-n Don't dereference symlinks - treat like normal file
-b Make a backup of the target (if exists) before link operation
-S suf Use suffix instead of ~ when making backup files
-T Treat LINK as a file, not DIR
-v Verbose
-- |
Contributor
Author
|
Thanks! Fix the tests (confirmed they run successfully :D) |
toote
approved these changes
Jan 19, 2026
Contributor
toote
left a comment
toote
left a comment
There was a problem hiding this comment.
I would have personally split the backend in two: one for gcloud and another for gsutil. And, for convenience, the gcs one to do auto-detection and just call the corresponding one. But I don't think that is 100% necessary.
It is to note, though, that the tests only cover the gsutil one so there are untested code paths left. But they can be corrected/added in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing the reviewer feedback from: #138
Mainly I'd really like this functionality merged so I can use it, so I thought I'd take a crack at addressing the comments.