Redirect stdin to the stubbed command to allow users to verify stub inputs #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hiya! I totally missed this. |
lox
reviewed
Aug 1, 2018
binstub
Outdated
| # in a subshell. Otherwise, log the failure. | ||
| if [ $result -eq 0 ] ; then | ||
| debug "running $command" | ||
| debug "command input is $input" |
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a feature that I needed for my tests.
Basically, we save the content of stdin early in the
binstubprocess to be able to redirect it to the stub command. This way, we can verify what input was given to our stub.STDIN is only read if it is not a tty, or test will wait forever for some user input.