Skip to content

Fix flags for FreeBSD/arm64 #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
timstpierre-tc wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix flags for FreeBSD/arm64 #181

timstpierre-tc wants to merge 6 commits into from

Conversation

@timstpierre-tc
Copy link

@timstpierre-tc timstpierre-tc commented Mar 25, 2024

Couldn't get this package to work with FreeBSD on arm64, and eventually figured out why.

  • Setting the Control flags with the baud rate seems to break things, specifically the word size. Removing that solved the issue.
  • The post-processing output flag is needed. Turning that flag off broke newline handling and control codes. In order to turn that on only for FreeBSD, a constant was added with set and clear values that can then be added in each os-specific file. I set the correct values for FreeBSD and then set zero values in the other UNIX os files. Hoping this should keep it working everywhere else (since I also tested on linux/arm64 and darwin/arm64 and it worked fine there).

-Confirmed setting baud rate and parity work correctly with the changes on FreeBSD/arm64.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@timstpierre-tc