Skip to content

Conversation

@Caellian
Copy link
Collaborator

@Caellian Caellian commented Dec 8, 2024

  • Moved wl protocol files to separate directory in src, as src dir is already waaay to crowded.

Tested adding xdg-output - which will be needed for fixing stuff like #2106

Src dir is already waaay to crowded. Also made it simpler to add
protocols in future (tried with xdg-output).

Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
@github-actions github-actions bot added sources PR modifies project sources build system related to build system (CMake) and/or building process/assumptions labels Dec 8, 2024
@netlify
Copy link

netlify bot commented Dec 8, 2024

Deploy Preview for conkyweb canceled.

Name Link
🔨 Latest commit 330200b
🔍 Latest deploy log https://app.netlify.com/sites/conkyweb/deploys/6755cb15fb42e7000818c0f6
Comment on lines +336 to +337
add_protocol(xdg-shell)
add_protocol(wlr-layer-shell v1)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR allows protocols to be added like this.

@Caellian Caellian changed the title Moved wl protocol files to separate directory in src Dec 8, 2024
@Caellian Caellian requested a review from brndnmtthws December 8, 2024 17:14
Copy link
Owner

@brndnmtthws brndnmtthws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@Caellian Caellian merged commit e20b0a9 into main Dec 8, 2024
38 checks passed
@Caellian Caellian deleted the dev/cmake-wl-protocols branch December 8, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build system related to build system (CMake) and/or building process/assumptions sources PR modifies project sources

3 participants