-
-
Notifications
You must be signed in to change notification settings - Fork 73
Add cloning function #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Code Climate has analyzed commit 1a97dfe and detected 107 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 83.9% (95% is the threshold). This pull request will bring the total coverage in the repository to 96.0% (-1.0% change). View more on Code Climate. |
|
@Koeng101 I would say that having the function work with raw sequences is the best way to go, You could eventually have layers of abstraction in terms of sequence/parts/io-format later on that call the sequence version of this. |
|
@rkrishnasanka I agree! |
|
@Koeng101 can you comment all exported functions? Code climates bots comments are super annoying to read through when doing code review. |
Co-authored-by: jkh <jonathan@expo.io>
Co-authored-by: jkh <jonathan@expo.io>
Co-authored-by: jkh <jonathan@expo.io>
Co-authored-by: jkh <jonathan@expo.io>
Co-authored-by: jkh <jonathan@expo.io>
|
To go over limitations:
|
Can you open a new pull request for this and explain why we aren't adding it yet?
I'm not sure what you mean here. Writing feels unclear. @Koeng101 is the second limitation documented in the example / code itself? |
Type IIG restriction enzymes like BcgI. It has a single recognition site, but multiple cut sites. We cannot yet simulate this. I'll in a specific example into the docs because I think that would help with clarity.
Should I just open an issue for this? |
Yes, I meant to say issue here my bad! |
|
🥳 |
The following branch "goldengatev1" has a functioning GoldenGate assembly script for BbsI. It works, but we should try to break it before integrating it, as well as debate the merits of my approach. It only operates on raw sequences as well - we should likely have an algorithm that works with Genbank files.
If we decide to do something else, we should close this pull request. This function, however, does work.