Add Codon Table JSON input / output #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 20, 2020 09:11
…quence file to where the optimization table is actually build. This change allows faithful representation of codon tables generated from Sequence files.
TimothyStiles
previously requested changes
Nov 21, 2020
TimothyStiles
approved these changes
Nov 21, 2020
Collaborator
TimothyStiles
left a comment
TimothyStiles
left a comment
There was a problem hiding this comment.
I approve these changes but perhaps there's someone else who can review it too?
Contributor
Author
|
Any suggestions? |
Collaborator
|
I'm not sure. What I think I'll do before we merge is actually look up what this PRs test coverage is then review it again or merge it if it's good enough. |
Contributor
Author
|
Any way to have a little bot that tells us that on the PRs directly or something? |
Contributor
Author
|
According to func ReadCodonJSON(path string) CodonTable {
file, err := ioutil.ReadFile(path)
if err != nil {
// return 0, fmt.Errorf("Failed to open file %s for unpack: %s", gzFilePath, err)
}Not really sure how to test that, but basically I have coverage for things other than that. This, btw, doesn't have a test for any of the other read functions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds features+test to import or export codon tables as JSON files. This does NOT add in that feature for the command line interface - I am building it to import as part of a webservice that supplies codon tables as JSON.
Probably good to add it into the CLI, but honestly I might need some instruction on how to do that. I can set up an issue to do that, probably can come later.