Make writes to temporary files in io tests #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkhales
force-pushed
the
@jkhales/clean-up-io-tests
branch
2 times, most recently
from
2b8dab3 to
97f657f
Compare
jkhales
force-pushed
the
@jkhales/clean-up-io-tests
branch
from
97f657f to
5e5711e
Compare
| defer os.RemoveAll(tmpDataDir) | ||
|
|
||
| scrubbedGbk = ReadGbk("data/t4_intron.gb") | ||
| scrubbedGb := ReadGbk("data/t4_intron.gb") |
TimothyStiles
approved these changes
May 15, 2021
Collaborator
TimothyStiles
left a comment
TimothyStiles
left a comment
There was a problem hiding this comment.
Overall this looks good and can be approved. Not sure why gbk is now gb but ¯_(ツ)_/¯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that not all files were cleaned up after running
go test:defer os.Removecalls next to the writes so it's easier to keep track of cleanup.TempDirso even in the case of a catastrophic failure, the file system will take care of clean up. This also isolates the test correctly so there won't be any chance of file name conflict.