Skip to content

Conversation

@Koeng101
Copy link
Contributor

Added Fasta subpackage parser. I moved the stuff from io.go and io_test.go to the parsers directory for a specific fasta parser and merged my concurrent fasta parser from #83 + Jordan Campbell fasta functions from #37 so that we don't have two alternative ways to parse fasta files.

Includes 100% test coverage, and all the tests and goodness from io.go.

@Koeng101
Copy link
Contributor Author

Fasta fails due to the CLI. Lemme figure this one out @TimothyStiles

@Koeng101
Copy link
Contributor Author

Oh crap, I have to go fix the CLI.

@TimothyStiles
Copy link
Collaborator

Oh crap, I have to go fix the CLI.

looool That dang CLI @Koeng101. So glad we're only supporting file conversion and hashing going forward. We may want to even just move that code to a new repo.

@TimothyStiles
Copy link
Collaborator

@Koeng101 got time to fix this and merge it with me?

@TimothyStiles TimothyStiles merged commit 17f27e4 into prime Jun 5, 2021
@delete-merged-branch delete-merged-branch bot deleted the fastaParser branch June 5, 2021 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants