Conversation
Prior to this change the test in winagent_test.rb was commented out. When we run bb on our dev desktops, the test task in hte Rakefile runs the winagent_test.rb and fails because the test runs on a linux machine In this commit we uncomment the test and remove it from the list of files run as part of the "test" task. I will add a new task in a followup commit to run windows specific tests
commit: 6c7988df7868ecfa183fe9778ef5ed5587210698 Author: Andres Jardon <amjardon@amazon.com> Date: 2023-03-20T20:06:16.000Z Source code changes and dependency updates for Ruby 3.1 and 3.2 support commit: 3aa58788849a414fb0ae6ddd94a96d8dbf696f92 Author: Andres Jardon <amjardon@amazon.com> Date: 2023-03-20T18:04:30.000Z Source code changes and dependency updates for Ruby 3.1 and 3.2 support commit: 77a4cc18f931284d4908a4f8bfa1854727e205ad Author: Andres Jardon <amjardon@amazon.com> Date: 2023-03-17T19:53:35.000Z Source code changes and dependency updates for Ruby 3.1 and 3.2 support
mwjones-aws
approved these changes
Apr 19, 2023
puneethnr
approved these changes
Apr 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*Issue #360
Description of changes: Please refer to above issue, for links to release notes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.