Upgraded a lot of libraries#286
Conversation
It wasn't passing because the reference name had spaces in the string (creating invalid references). The updated git library has enforced stricter checks on the ref name.
Branch creation now forces the use of at least one slash "/" for better branch self-description. This sound quite arbitrary from the go-git library, but that's how it is.
alessio-perugini
left a comment
alessio-perugini
left a comment
There was a problem hiding this comment.
The test changes/refactor looks good.
It did not: https://downloads.arduino.cc/libraries/logs/github.com/gooddisplayshare/ESP32epd/ This shows that libraries-repository-engine is seeing a value of https://github.com/gooddisplayshare/ESP32epd/blob/v1.0.1/library.properties#L2 https://github.com/gooddisplayshare/ESP32epd/blob/v1.0.2/library.properties#L2 https://github.com/gooddisplayshare/ESP32epd/blob/v1.0.3/library.properties#L2 I moved #287 back to the "Backlog" column in the "Tooling Team" project. |
|
Ah, nevermind. I thought this made it into the release, but then I noticed the little "This PR’s merge commit doesn’t appear in any tags" Refined GitHub added to the bottom of the PR thread after I commented, and I see that it is not in the release. |
|
It should be all resolved now 👍🏼 |
3 participants
This PR upgrades all the dependencies, and also go-git, it should solve the issue in #287