Skip to content

fix: retry compilation if grpc client needs to be reinitialized #2548

Merged
davegarthsimpson merged 3 commits into
mainfrom
#2547
Nov 21, 2024
Merged

fix: retry compilation if grpc client needs to be reinitialized #2548
davegarthsimpson merged 3 commits into
mainfrom
#2547

Conversation

@giacomocusinato

@giacomocusinato giacomocusinato commented Oct 30, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Motivation

Closes: #2547

Change description

Catch invalid instance error during compilation, refresh grpc client and retry.

Other information

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)
@giacomocusinato
fix: use Status enum for status code in ServiceError type guards
d3306e0 
This change resolves the issue where the intersection of `ServiceError` error codes of type `number` resulted in the `never` type due to conflict between number and `State` enum if `StatusObject`
@giacomocusinato
feat: add isInvalidArgument type guard to ServiceError
a52bce2
@per1234 per1234 linked an issue Oct 30, 2024 that may be closed by this pull request
Modification of installed core files breaks compilation #2547
Closed
3 tasks
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself topic: CLI Related to Arduino CLI labels Oct 30, 2024
dankeboy36
dankeboy36 reviewed Oct 30, 2024
View reviewed changes

@dankeboy36 dankeboy36 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking great.

Why not handle the error on the backend without sending it back to the FE? Is there a technical limitation? Thank you! (Related #2500)
Comment thread arduino-ide-extension/src/node/core-service-impl.ts Outdated

if (
ServiceError.isInvalidArgument(error) &&
error.details.includes('instance is no longer valid')

@dankeboy36 dankeboy36 Oct 30, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should happen when the selected language is, for example, German, and there is a translation for this error message for the CLI?

@giacomocusinato giacomocusinato Nov 4, 2024

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm now extracting the error type from the error metadata 👍
@giacomocusinato

giacomocusinato commented Nov 4, 2024

Copy link
Copy Markdown
Collaborator Author

Thanks for the review @dankeboy36!
You're right, would be best to handle the error directly on the backend. Initially I found a bit confusing code-wise restarting the compile stream in the same method, but I've proposed a solution now. If that works I might use the same approach with the logic in #2500
@davegarthsimpson davegarthsimpson merged commit 4cf9909 into main Nov 21, 2024
@davegarthsimpson davegarthsimpson deleted the #2547 branch November 21, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: CLI Related to Arduino CLI topic: code Related to content of the project itself type: enhancement Proposed improvement

4 participants

@giacomocusinato @davegarthsimpson @dankeboy36 @per1234