Error message if upload is not possible#1353
Merged
Merged
Conversation
kittaakos
approved these changes
Aug 25, 2022
Contributor
There was a problem hiding this comment.
The code looks good to me.
I am not familiar with the board user fields logic, maybe we should change
if (this.boardRequiresUserFields && !this.cachedUserFields.has(key)) {to
if (this.boardRequiresUserFields && key && !this.cachedUserFields.has(key)) {
davegarthsimpson
approved these changes
Aug 25, 2022
per1234
requested changes
Aug 25, 2022
kittaakos
added
type: enhancement
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
If the user presses the upload button and no board is selected, a message should appear warning what went wrong while uploading. Since verify takes place before upload, the same message that is given when the user tries to compile a sketch without selecting a board should be shown. On the other hand, this message is not very clear, so it should be updated.
Change description
Communicate to user when upload is impossible due to no board selection.
Make error message from compiling without board selected more user friendly.
Other information
Closes #845.
Closes #62.
This fix depends on the changes made here: arduino/arduino-cli#1848. Without it it is not possible to verify that #62 is resolved.
Reviewer checklist