Quality: Invalid use of Go's `new` builtin — will not compile or produces wrong pointer #3229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

kumburovicbranko682-boop wants to merge 1 commit into arduino:master from kumburovicbranko682-boop:contribai/improve/quality/invalid-use-of-go-s-new-builtin-will-not

+2 −2

commands/service_settings.go

-Original file line number
+Diff line change
@@ Expand Up / @@ -70,14 +70,14 @@ @@
     	}
     	if builtinLibs := s.settings.IDEBuiltinLibrariesDir(); builtinLibs != nil {
-    		conf.Directories.Builtin.Libraries = new(builtinLibs.String())
+    		conf.Directories.Builtin.Libraries = f.ToPtr(builtinLibs.String())
     	}
     	if ua := s.settings.ExtraUserAgent(); ua != "" {
     		conf.Network.ExtraUserAgent = &ua
     	}
     	if proxy, err := s.settings.NetworkProxy(); err == nil && proxy != nil {
-    		conf.Network.Proxy = new(proxy.String())
+    		conf.Network.Proxy = f.ToPtr(proxy.String())
     	}
     	if logFile := s.settings.LoggingFile(); logFile != nil {
@@ Expand Down @@

Uh oh!

Quality: Invalid use of Go's new builtin — will not compile or produces wrong pointer #3229

Are you sure you want to change the base?

Quality: Invalid use of Go's new builtin — will not compile or produces wrong pointer #3229

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

GitHub Actions / test (macos-latest)

GitHub Actions / check-style (.)

GitHub Actions / test-integration (macos-latest, profiles)

GitHub Actions / test-integration (macos-latest, compile_3)

GitHub Actions / test-integration (macos-latest, upload)

GitHub Actions / test-integration (macos-latest, lib)

GitHub Actions / test-integration (macos-latest, outdated)

GitHub Actions / test-integration (macos-latest, debug)

GitHub Actions / test-integration (macos-latest, core_2)

GitHub Actions / test-integration (macos-latest, sketch)

GitHub Actions / test (ubuntu-latest)

GitHub Actions / test-integration (macos-latest, compile_1)

GitHub Actions / test-integration (macos-latest, upgrade)

GitHub Actions / test-integration (macos-latest, compile_5)

GitHub Actions / test-integration (macos-latest, main)

GitHub Actions / test-integration (macos-latest, compile_2)

GitHub Actions / test-integration (macos-latest, compile_4)

GitHub Actions / test-integration (macos-latest, completion)

GitHub Actions / test-integration (macos-latest, upload_mock)

GitHub Actions / test-integration (macos-latest, update)

GitHub Actions / test-integration (macos-latest, cache)

GitHub Actions / check-outdated (.)

GitHub Actions / test-integration (ubuntu-latest, compile_4)

GitHub Actions / test-integration (macos-latest, daemon)

GitHub Actions / test-integration (macos-latest, board)

GitHub Actions / test-integration (ubuntu-latest, upload)

GitHub Actions / test-integration (ubuntu-latest, compile_3)

GitHub Actions / test-integration (ubuntu-latest, completion)

GitHub Actions / test-integration (ubuntu-latest, compile_5)

GitHub Actions / test-integration (ubuntu-latest, outdated)

GitHub Actions / test-integration (ubuntu-latest, profiles)

GitHub Actions / Create artifact Linux_X86-32

GitHub Actions / test-integration (ubuntu-latest, compile_2)

GitHub Actions / Create artifact Linux_X86-64

GitHub Actions / test-integration (ubuntu-latest, core)

GitHub Actions / test-integration (ubuntu-latest, monitor)

GitHub Actions / test-integration (macos-latest, core)

GitHub Actions / test-integration (macos-latest, config)

GitHub Actions / test-integration (ubuntu-latest, upgrade)

GitHub Actions / test-integration (macos-latest, monitor)

GitHub Actions / Create artifact Windows_X86-64

GitHub Actions / test-integration (ubuntu-latest, core_2)

GitHub Actions / Create artifact Windows_X86-32

GitHub Actions / test-integration (ubuntu-latest, debug)

GitHub Actions / test-integration (ubuntu-latest, lib)

GitHub Actions / test-integration (ubuntu-latest, compile_1)

GitHub Actions / test-integration (ubuntu-latest, daemon)

GitHub Actions / test-integration (ubuntu-latest, config)

GitHub Actions / test-integration (ubuntu-latest, upload_mock)

GitHub Actions / test-integration (ubuntu-latest, sketch)

GitHub Actions / test-integration (ubuntu-latest, update)

GitHub Actions / test-integration (ubuntu-latest, main)

GitHub Actions / test-integration (ubuntu-latest, cache)

GitHub Actions / test-integration (ubuntu-latest, board)

GitHub Actions / Create artifact Linux_ARMv6

GitHub Actions / Create artifact Linux_ARMv7

GitHub Actions / Create artifact Linux_ARM64

GitHub Actions / test-integration (windows-latest, lib)

GitHub Actions / test-integration (windows-latest, upload_mock)

GitHub Actions / test-integration (windows-latest, cache)

GitHub Actions / test-integration (windows-latest, config)

GitHub Actions / test-integration (windows-latest, compile_5)

GitHub Actions / test-integration (windows-latest, sketch)

GitHub Actions / test-integration (windows-latest, main)

GitHub Actions / test-integration (windows-latest, completion)

GitHub Actions / test-integration (windows-latest, upload)

GitHub Actions / test-integration (windows-latest, outdated)

GitHub Actions / test-integration (windows-latest, compile_1)

GitHub Actions / test (windows-latest)

GitHub Actions / test-integration (windows-latest, profiles)

GitHub Actions / test-integration (windows-latest, core_2)

Quality: Invalid use of Go's `new` builtin — will not compile or produces wrong pointer #3229

Quality: Invalid use of Go's `new` builtin — will not compile or produces wrong pointer #3229