Clarify upload port message when no new port appears after reset#3218
Open
nitishagar wants to merge 1 commit into
Open
Clarify upload port message when no new port appears after reset#3218nitishagar wants to merge 1 commit into
nitishagar wants to merge 1 commit into
Conversation
After a 1200bps touch reset, if no new upload port is detected the CLI printed "No upload port found, using <port> as fallback", which reads as if a port other than the selected one is being used (it actually prints the originally selected port). Reword it to "No new upload port detected after reset; continuing with the originally selected port <port>". The "No device found on ..." line and the cu./tty. port resolution mentioned in the issue come from the external bossac tool and serial-discovery, and are out of scope here. Fixes arduino#3075
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3218 +/- ##
==========================================
+ Coverage 69.43% 69.44% +0.01%
==========================================
Files 252 252
Lines 19595 19595
==========================================
+ Hits 13606 13608 +2
+ Misses 4718 4717 -1
+ Partials 1271 1270 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reword the upload "fallback" message printed after a 1200bps touch reset.
Why
When no new upload port is detected after the reset, the CLI printed:
which reads as if a port other than the one the user selected is being used — even though it actually prints the originally selected port. See #3075.
How
Reword to:
Note: the
No device found on ...line and thecu./tty.port resolution also mentioned in the issue originate in the externalbossactool and the pluggable serial-discovery, so they are out of scope for this change.Fixes #3075