Support building for OpenBSD host#3208
Open
reezer wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3208 +/- ##
==========================================
+ Coverage 69.43% 69.45% +0.01%
==========================================
Files 252 252
Lines 19565 19584 +19
==========================================
+ Hits 13585 13602 +17
+ Misses 4719 4712 -7
- Partials 1261 1270 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
GOOS=openbsd go build ./....will not fail anymore and build a binaryWhat is the current behavior?
GOOS=openbsd go build ./....fails with:What is the new behavior?
An arduino-cli binary is created.
Does this PR introduce a breaking change, and is titled accordingly?
No
Other information
It might make sense to do the same change for NetBSD and DragonFly as well. However this doesn't seem to currently fix compilation. Maybe it makes sense to create an
_other.goor_unsupported.goor_bsd.gofile so people right away see the actual error instead of the file/os target not existing?