fix: use build.project_name for bootloader artifacts#3164
Open
officialasishkumar wants to merge 1 commit into
Open
fix: use build.project_name for bootloader artifacts#3164officialasishkumar wants to merge 1 commit into
officialasishkumar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
build.project_namevalues.UPGRADING.mdhas been updated with a migration guide (for breaking changes) - not applicable; this is not a breaking change.configuration.schema.jsonupdated if new parameters are added. - not applicable; no configuration parameters are added.What kind of change does this PR introduce?
Bug fix.
What is the current behavior?
Fixes #3108.
When
compileis run with a custom--build-property build.project_name=..., the main output artifacts use the custom project name, but the bootloader merge step still looks for artifacts named after the original sketch file. As a result,.with_bootloader.hexand.with_bootloader.binare not generated for the custom project name.What is the new behavior?
The bootloader merge step uses the resolved
build.project_name, falling back to the sketch main filename only when the property is unavailable. This produces the expected custom-named bootloader artifacts alongside the other custom-named build outputs.Does this PR introduce a breaking change, and is titled accordingly?
No.
Other information
Validation run locally:
go test ./internal/arduino/builder -run TestMergeSketchWithBootloaderUsesBuildProjectName -count=1go test ./internal/arduino/builder -count=1go buildgo test ./internal/integrationtest/compile_1 -run '^TestCompile$/^WithCustomBuildPath$/^OutsideSketchWithBuildProjectName$' -count=1 -timeout 20m