fix: Arduino Preprocess should always run if the target file is missing#3149
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3149 +/- ##
==========================================
+ Coverage 69.36% 69.38% +0.02%
==========================================
Files 252 252
Lines 19422 19505 +83
==========================================
+ Hits 13472 13534 +62
- Misses 4706 4714 +8
- Partials 1244 1257 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7116ba3 to
77f88a2
Compare
giulio93
approved these changes
Apr 7, 2026
ce8e048 to
e1b5cb9
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
This is a regression introduced in #3112, but not yet released.
What is the current behavior?
If an error occurs during Arduino preprocessing, the preprocessed sketch is not generated, and the error is displayed.
By the way, if another compile happens immediately without changing the sketch, the Arduino Preprocessing is skipped because the sketch is "unchanged." As a result, the previously displayed error is no longer shown, and the compile continues, leading to another unrelated error (probably "missing
setup" or "missingloop" because the preprocessed sketch hasn't been generated).What is the new behavior?
If the preprocessed sketch hasn't been created, the Arduino Preprocessor is always executed, even if the sketch is unchanged.
Does this PR introduce a breaking change, and is titled accordingly?
Other information