Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
c7d0cb4
Added gRPC functions to manage libraries in profiles
cmaglie Oct 3, 2025
92cf64f
Removed ProfileDump gRPC command.
cmaglie Oct 6, 2025
ed5d6a2
Moved SketchProfileLibraryReference in the proper commono.proto file
cmaglie Oct 6, 2025
c74f073
linter: removed unneeded type specification
cmaglie Oct 6, 2025
34c378c
Renamed SketchProfileLibraryReference -> ProfileLibraryReference
cmaglie Oct 22, 2025
0c78b3f
Renamed InitProfile -> ProfileCreate
cmaglie Oct 22, 2025
3c5a3c9
Small refactoring, no code change
cmaglie Oct 23, 2025
4d78f7f
Fixed error messages
cmaglie Oct 23, 2025
d4cbad2
Removed unnecessary type specifier
cmaglie Oct 24, 2025
140c069
Refactored libraryResolveDependencies.
cmaglie Oct 27, 2025
5ac03d8
Added support for 'dependency:' field in profiles libraries
cmaglie Oct 29, 2025
e17724b
ProfileLibAdd and ProfileLibRemove can now cleanup unneeded dependencies
cmaglie Oct 29, 2025
4bb86e7
Better error messages
cmaglie Nov 21, 2025
f520cb9
Simplified Profile.RemoveLibrary(...) method.
cmaglie Nov 21, 2025
4e80e73
Fixed algorithm for determination of required deps
cmaglie Nov 21, 2025
dbafbe6
Updated docs
cmaglie Nov 25, 2025
4f527c0
Rename DuplicateProfileError -> ProfileAlreadyExitsError
cmaglie Nov 26, 2025
1909ab7
Removed useless field in gRPC ProfileCreateResponse
cmaglie Nov 26, 2025
8b4b3a5
fix: ProfileCreate sets the new profile as default only if asked to d…
cmaglie Nov 26, 2025
ad5d941
Improved docs
cmaglie Dec 1, 2025
3a14601
Applied code review suggestion
cmaglie Dec 1, 2025
2aa7e32
Using cmp.Or helper
cmaglie Dec 1, 2025
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Renamed SketchProfileLibraryReference -> ProfileLibraryReference
  • Loading branch information
cmaglie committed Nov 25, 2025
commit 34c378c84f9868c3000ddc8fcbe3cf7cf13bfd85
16 changes: 8 additions & 8 deletions internal/arduino/sketch/profiles.go
Original file line number Diff line number Diff line change
Expand Up @@ -420,19 +420,19 @@ func (l *ProfileLibraryReference) Match(other *ProfileLibraryReference) bool {
}

// ToRpc converts this ProfileLibraryReference to an rpc.ProfileLibraryReference
func (l *ProfileLibraryReference) ToRpc() *rpc.SketchProfileLibraryReference {
func (l *ProfileLibraryReference) ToRpc() *rpc.ProfileLibraryReference {
if l.InstallDir != nil {
return &rpc.SketchProfileLibraryReference{
Library: &rpc.SketchProfileLibraryReference_LocalLibrary_{
LocalLibrary: &rpc.SketchProfileLibraryReference_LocalLibrary{
return &rpc.ProfileLibraryReference{
Library: &rpc.ProfileLibraryReference_LocalLibrary_{
LocalLibrary: &rpc.ProfileLibraryReference_LocalLibrary{
Path: l.InstallDir.String(),
},
},
}
}
return &rpc.SketchProfileLibraryReference{
Library: &rpc.SketchProfileLibraryReference_IndexLibrary_{
IndexLibrary: &rpc.SketchProfileLibraryReference_IndexLibrary{
return &rpc.ProfileLibraryReference{
Library: &rpc.ProfileLibraryReference_IndexLibrary_{
IndexLibrary: &rpc.ProfileLibraryReference_IndexLibrary{
Name: l.Library,
Version: l.Version.String(),
},
Expand All @@ -441,7 +441,7 @@ func (l *ProfileLibraryReference) ToRpc() *rpc.SketchProfileLibraryReference {
}

// FromRpcProfileLibraryReference converts an rpc.ProfileLibraryReference to a ProfileLibraryReference
func FromRpcProfileLibraryReference(l *rpc.SketchProfileLibraryReference) (*ProfileLibraryReference, error) {
func FromRpcProfileLibraryReference(l *rpc.ProfileLibraryReference) (*ProfileLibraryReference, error) {
if localLib := l.GetLocalLibrary(); localLib != nil {
path := paths.New(localLib.GetPath())
if path == nil {
Expand Down
12 changes: 6 additions & 6 deletions internal/cli/feedback/result/rpc.go
Original file line number Diff line number Diff line change
Expand Up @@ -1126,23 +1126,23 @@ func NewIndexUpdateReport_Status(r rpc.IndexUpdateReport_Status) IndexUpdateRepo
}
}

type SketchProfileLibraryReference_LocalLibraryResult struct {
type ProfileLibraryReference_LocalLibraryResult struct {
Path string `json:"path,omitempty"`
}

func NewSketchProfileLibraryReference_LocalLibraryResult(resp *rpc.SketchProfileLibraryReference_LocalLibrary) *SketchProfileLibraryReference_LocalLibraryResult {
return &SketchProfileLibraryReference_LocalLibraryResult{
func NewProfileLibraryReference_LocalLibraryResult(resp *rpc.ProfileLibraryReference_LocalLibrary) *ProfileLibraryReference_LocalLibraryResult {
return &ProfileLibraryReference_LocalLibraryResult{
Path: resp.GetPath(),
}
}

type SketchProfileLibraryReference_IndexLibraryResult struct {
type ProfileLibraryReference_IndexLibraryResult struct {
Name string `json:"name,omitempty"`
Version string `json:"version,omitempty"`
}

func NewSketchProfileLibraryReference_IndexLibraryResult(resp *rpc.SketchProfileLibraryReference_IndexLibrary) *SketchProfileLibraryReference_IndexLibraryResult {
return &SketchProfileLibraryReference_IndexLibraryResult{
func NewProfileLibraryReference_IndexLibraryResult(resp *rpc.ProfileLibraryReference_IndexLibrary) *ProfileLibraryReference_IndexLibraryResult {
return &ProfileLibraryReference_IndexLibraryResult{
Name: resp.GetName(),
Version: resp.GetVersion(),
}
Expand Down
12 changes: 6 additions & 6 deletions internal/cli/feedback/result/rpc_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -234,13 +234,13 @@ func TestAllFieldAreMapped(t *testing.T) {
indexUpdateReportResult := result.NewIndexUpdateReportResult(indexUpdateReportRpc)
mustContainsAllPropertyOfRpcStruct(t, indexUpdateReportRpc, indexUpdateReportResult)

sketchProfileLibraryReference_IndexLibraryRpc := &rpc.SketchProfileLibraryReference_IndexLibrary{}
sketchProfileLibraryReference_IndexLibraryResult := result.NewSketchProfileLibraryReference_IndexLibraryResult(sketchProfileLibraryReference_IndexLibraryRpc)
mustContainsAllPropertyOfRpcStruct(t, sketchProfileLibraryReference_IndexLibraryRpc, sketchProfileLibraryReference_IndexLibraryResult)
profileLibraryReference_IndexLibraryRpc := &rpc.ProfileLibraryReference_IndexLibrary{}
profileLibraryReference_IndexLibraryResult := result.NewProfileLibraryReference_IndexLibraryResult(profileLibraryReference_IndexLibraryRpc)
mustContainsAllPropertyOfRpcStruct(t, profileLibraryReference_IndexLibraryRpc, profileLibraryReference_IndexLibraryResult)

sketchProfileLibraryReference_LocalLibraryRpc := &rpc.SketchProfileLibraryReference_LocalLibrary{}
sketchProfileLibraryReference_LocalLibraryResult := result.NewSketchProfileLibraryReference_LocalLibraryResult(sketchProfileLibraryReference_LocalLibraryRpc)
mustContainsAllPropertyOfRpcStruct(t, sketchProfileLibraryReference_LocalLibraryRpc, sketchProfileLibraryReference_LocalLibraryResult)
profileLibraryReference_LocalLibraryRpc := &rpc.ProfileLibraryReference_LocalLibrary{}
profileLibraryReference_LocalLibraryResult := result.NewProfileLibraryReference_LocalLibraryResult(profileLibraryReference_LocalLibraryRpc)
mustContainsAllPropertyOfRpcStruct(t, profileLibraryReference_LocalLibraryRpc, profileLibraryReference_LocalLibraryResult)
}

func TestEnumsMapsEveryRpcCounterpart(t *testing.T) {
Expand Down
Loading