Skip to content

Add first set of profile commands #2917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Add first set of profile commands #2917

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c282cc6
Add `profile init` command
MatteoPologruto May 21, 2025
d3d7a59
Add `profile lib add` command
MatteoPologruto May 22, 2025
f98bf7d
Add `profile lib remove` command
MatteoPologruto May 22, 2025
235005d
Support default profiles
MatteoPologruto May 23, 2025
d47a687
Switch to structured error
MatteoPologruto May 23, 2025
4d167f3
Add more test cases
MatteoPologruto May 23, 2025
a2c86ef
Add `profile set-default` command
MatteoPologruto May 23, 2025
0d295ca
Add `profile dump` command
MatteoPologruto May 27, 2025
c8a3e4e
Add comments to functions
MatteoPologruto May 27, 2025
a99efdd
Fix spacing
MatteoPologruto May 27, 2025
8f009bc
Apply review suggestions
MatteoPologruto May 30, 2025
f5943ab
Generate a correct yaml when properties are empty
MatteoPologruto May 30, 2025
5381938
Refactor preconditions checks
MatteoPologruto May 30, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Generate a correct yaml when properties are empty
  • Loading branch information
@MatteoPologruto
MatteoPologruto committed May 30, 2025
commit f5943ab747df3b5217ad44b8af499182d7c6dec3
2 changes: 1 addition & 1 deletion commands/service_profile_init.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ func (s *arduinoCoreServerImpl) InitProfile(ctx context.Context, req *rpc.InitPr
}

if !projectFilePath.Exist() {
err := projectFilePath.WriteFile([]byte("profiles:\n"))
err := projectFilePath.WriteFile([]byte("profiles: {}\n"))
if err != nil {
return nil, err
}
Expand Down
6 changes: 6 additions & 0 deletions internal/arduino/sketch/profiles.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,9 @@ type ProfileRequiredPlatforms []*ProfilePlatformReference

// AsYaml outputs the required platforms as Yaml
func (p *ProfileRequiredPlatforms) AsYaml() string {
if len(*p) == 0 {
return " platforms: []\n"
}
res := " platforms:\n"
for _, platform := range *p {
res += platform.AsYaml()
Expand All @@ -202,6 +205,9 @@ type ProfileRequiredLibraries []*ProfileLibraryReference

// AsYaml outputs the required libraries as Yaml
func (p *ProfileRequiredLibraries) AsYaml() string {
if len(*p) == 0 {
return " libraries: []\n"
}
res := " libraries:\n"
for _, lib := range *p {
res += lib.AsYaml()
Expand Down
6 changes: 3 additions & 3 deletions internal/integrationtest/profiles/profiles_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ func initNoProfile(t *testing.T, env *integrationtest.Environment, cli *integrat
require.FileExists(t, projectFile.String())
fileContent, err := projectFile.ReadFile()
require.NoError(t, err)
require.Equal(t, "profiles:\n", string(fileContent))
require.Equal(t, "profiles: {}\n", string(fileContent))
}

func initWithCorrectFqbn(t *testing.T, env *integrationtest.Environment, cli *integrationtest.ArduinoCLI) {
Expand All @@ -195,7 +195,7 @@ func initWithCorrectFqbn(t *testing.T, env *integrationtest.Environment, cli *in
require.FileExists(t, projectFile.String())
fileContent, err := projectFile.ReadFile()
require.NoError(t, err)
require.Equal(t, "profiles:\n Uno:\n fqbn: arduino:avr:uno\n platforms:\n - platform: arduino:avr (1.8.6)\n libraries:\n\ndefault_profile: Uno\n", string(fileContent))
require.Equal(t, "profiles:\n Uno:\n fqbn: arduino:avr:uno\n platforms:\n - platform: arduino:avr (1.8.6)\n libraries: []\n\ndefault_profile: Uno\n", string(fileContent))
}

func initWithWrongFqbn(t *testing.T, env *integrationtest.Environment, cli *integrationtest.ArduinoCLI) {
Expand Down Expand Up @@ -315,7 +315,7 @@ func removeLibFromDefaultProfile(t *testing.T, env *integrationtest.Environment,
require.NoError(t, err)
fileContent, err := cli.SketchbookDir().Join("Simple", "sketch.yaml").ReadFile()
require.NoError(t, err)
require.Equal(t, "profiles:\n Uno:\n fqbn: arduino:avr:uno\n platforms:\n - platform: arduino:avr (1.8.6)\n libraries:\n\ndefault_profile: Uno\n", string(fileContent))
require.Equal(t, "profiles:\n Uno:\n fqbn: arduino:avr:uno\n platforms:\n - platform: arduino:avr (1.8.6)\n libraries: []\n\ndefault_profile: Uno\n", string(fileContent))
}

func addInexistentLibToDefaultProfile(t *testing.T, env *integrationtest.Environment, cli *integrationtest.ArduinoCLI) {
Expand Down