Skip to content

fix: handle partial downloaded model#479

Draft
lucarin91 wants to merge 3 commits into
mainfrom
feat/models-download-flow-handle-partial-download
Draft

fix: handle partial downloaded model#479
lucarin91 wants to merge 3 commits into
mainfrom
feat/models-download-flow-handle-partial-download

Conversation

@lucarin91

Copy link
Copy Markdown
Contributor

Motivation

Change description

Additional Notes

Reviewer checklist

  • PR addresses a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.
Comment thread internal/orchestrator/modelsindex/models_index.go Outdated

// resolveArtifactPaths translates artifact paths emitted by a handler
// (container-absolute or relative to the volume mount) into absolute host paths.
func resolveArtifactPaths(bindVolumes []string, artifacts []string) []*paths.Path {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit test for this could be useful to avoid regression

Base automatically changed from feat/models-download-flow to main June 26, 2026 15:16
@lucarin91 lucarin91 force-pushed the feat/models-download-flow-handle-partial-download branch from b0a2202 to d23bd08 Compare June 26, 2026 15:23
@per1234 per1234 added the bug Something isn't working label Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

3 participants