Skip to content

adding inline json output stream#478

Open
mirkoCrobu wants to merge 7 commits into
mainfrom
refatoring_init_output
Open

adding inline json output stream#478
mirkoCrobu wants to merge 7 commits into
mainfrom
refatoring_init_output

Conversation

@mirkoCrobu

@mirkoCrobu mirkoCrobu commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Motivation

closes https://github.com/bcmi-labs/orchestrator/issues/521 (check it for the full context, limitation, integration, realated issue)

Change description

  • Single typed InitEvent callback (log/progress) as the only path to stdout.
  • Per-layer Docker logs removed and replaced by progress aggregated globally across all images.
  • Added --json-stream flag to system init, emitting JSONL with type, source, label, current, total, percent fields.
  • The source field (docker/libs/platform) it will be used by the consumers (it will be used in the upgrade flow, where system init is called as a sub-process to distinguish between the update source events): I preferred to keep all the logs instead of returning just the Docker ones to avoid losing logs.
  • Disk space check refactoring(GetBytesToDownload removed).

Additional Notes

Reviewer checklist

  • PR addresses a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.
@per1234 per1234 added the enhancement New feature or request label Jun 25, 2026
@mirkoCrobu

Copy link
Copy Markdown
Contributor Author

arduino-app-cli system init --json-stream

image image image
@mirkoCrobu

Copy link
Copy Markdown
Contributor Author

arduino-app-cli system init

image
@mirkoCrobu mirkoCrobu marked this pull request as ready for review June 26, 2026 07:31
@mirkoCrobu mirkoCrobu changed the title refactoring call back system init Jun 26, 2026
@mirkoCrobu mirkoCrobu requested a review from a team June 26, 2026 13:03
@mirkoCrobu mirkoCrobu force-pushed the refatoring_init_output branch from a4b57dd to c34edb1 Compare June 28, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

2 participants