Using licensed-notice-deduplicate to reduce NOTICE size#442
Open
cmaglie wants to merge 3 commits into
Open
Conversation
martacarbone
approved these changes
Jun 16, 2026
Xayton
approved these changes
Jun 17, 2026
Xayton
requested changes
Jun 17, 2026
Contributor
There was a problem hiding this comment.
It looks like the copyright file (debian/arduino-app-cli/usr/share/doc/arduino-app-cli/copyright) does not contain the full list of licenses. We probably removed it when the file became too big, but it might be time to restore it now.
If I'm not wrong, the suggested format for the debian/copyright file should be DEP-5, but AFAIK we are not using it in other packages we create (like arduino-router).
See this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I've made a tool to reduce the license duplications in the NOTICE file.
Change description
This PR includes the resulting NOTICE file to help assess the impact.
When two or more packages share the same license (exact match), they will be grouped as follows:
Turns out that this method is quite effective for the golang + licensed combo, for the following reasons:
licensedgenerates a NOTICE for each main package and for all sub-packages of the main package, even if they share the same license in 99.9% of the cases.In our case, the size reduction is remarkable, since we go from 13.8MB to 1.3MB (~90% reduction), while keeping the file perfectly readable.
Additional Notes
Reviewer checklist
main.