Skip to content

Fix for Serial flush() returning before transmission has completed #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pennam merged 2 commits into from
Nov 29, 2024
Merged

Fix for Serial flush() returning before transmission has completed #405

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
443a404
Serial: split uart events TX_COMPLETE from TX_DATA_EMPTY
Hsubtnarg May 28, 2024
51e2905
Serial: initialize tx flags to avoid locks
pennam Nov 29, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Serial: initialize tx flags to avoid locks
  • Loading branch information
@pennam
pennam committed Nov 29, 2024
commit 51e2905a93b4bde2daf97622d7d8a8593b9f8f62
2 changes: 2 additions & 0 deletions cores/arduino/Serial.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,8 @@ UART::UART(int _pin_tx, int _pin_rx, int _pin_rts, int _pin_cts):
rx_pin(_pin_rx),
rts_pin(_pin_rts),
cts_pin(_pin_cts),
tx_empty(true),
tx_complete(true),
init_ok(false) {
/* -------------------------------------------------------------------------- */
uart_cfg.txi_irq = FSP_INVALID_VECTOR;
Expand Down