Skip to content

Reduce WiFiS3 warnings #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pennam merged 8 commits into from
Nov 28, 2024
Merged

Reduce WiFiS3 warnings #404

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
983e92b
WiFiUdp: fix Wsign-compare
pennam Nov 28, 2024
1b27373
WiFiSSLClient: fix Wsign-compare
pennam Nov 28, 2024
ba39680
WiFiFileSystem: add missing return value
pennam Nov 28, 2024
9172976
WiFiClient: fix Wreorder
pennam Nov 28, 2024
0a0e7a4
WiFiClient: fix Wsign-compare
pennam Nov 28, 2024
118cdb0
WiFi: remove unused variable
pennam Nov 28, 2024
6bac645
Modem: suppress Wunused-parameter
pennam Nov 28, 2024
75bbb30
Modem: add explicit fall through
pennam Nov 28, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
WiFiClient: fix Wsign-compare
  • Loading branch information
@pennam
pennam committed Nov 28, 2024
commit 0a0e7a4bf884457268bb27f340f0daf9eea7fd13
4 changes: 2 additions & 2 deletions libraries/WiFiS3/src/WiFiClient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ int WiFiClient::_read() {

if(modem.write(string(PROMPT(_CLIENTRECEIVE)),res, "%s%d,%d\r\n" , CMD_WRITE(_CLIENTRECEIVE), _sock, size)) {
if(res.size() > 0) {
for(int i = 0, rv = 0; i < size && i < res.size(); i++) {
for(uint32_t i = 0, rv = 0; i < size && i < res.size(); i++) {
rx_buffer->store((uint8_t)res[i]);
rv++;
}
Expand Down Expand Up @@ -168,7 +168,7 @@ int WiFiClient::read(uint8_t *buf, size_t size) {
int rv = 0;
bool go_on = true;
if(_sock >= 0 && rx_buffer != nullptr) {
for(int i = 0; i < size && go_on; i++) {
for(size_t i = 0; i < size && go_on; i++) {
bool is_read = false;
*(buf+i) = rx_buffer->read(&is_read);
if(is_read) {
Expand Down