Skip to content

Lwip wrapper memory issues #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
andreagilardoni wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Lwip wrapper memory issues #153

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4ba1866
Provided a destructor for lwipClient
andreagilardoni Sep 26, 2023
e66f5cf
added check when pbuffer_get_data returns error
andreagilardoni Sep 26, 2023
3f1ee3a
added move constructor
andreagilardoni Sep 28, 2023
804d61d
made operators more efficient
andreagilardoni Sep 28, 2023
7bf4a56
added destructor for ssl client
andreagilardoni Sep 28, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Provided a destructor for lwipClient 
Provided a destructor that takes care of deallocating the _tcp_client
only when allocated with mem_alloc() and not passed in the constructor
  • Loading branch information
@andreagilardoni
andreagilardoni committed Sep 28, 2023
commit 4ba1866fcea1b30739df00b89e1c8beddc7ef222
19 changes: 16 additions & 3 deletions libraries/lwIpWrapper/src/lwipClient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ extern "C" {

/* -------------------------------------------------------------------------- */
lwipClient::lwipClient()
: _tcp_client(NULL)
: _tcp_client(NULL), _provided_tcp_client(false)
{
}
/* -------------------------------------------------------------------------- */
Expand All @@ -17,15 +17,28 @@ lwipClient::lwipClient()
sketches but sock is ignored. */
/* -------------------------------------------------------------------------- */
lwipClient::lwipClient(uint8_t sock)
: _tcp_client(NULL)
: _tcp_client(NULL), _provided_tcp_client(false)

{
}
/* -------------------------------------------------------------------------- */

/* -------------------------------------------------------------------------- */
lwipClient::lwipClient(struct tcp_struct* tcpClient)
: _tcp_client(tcpClient), _provided_tcp_client(true)

{
_tcp_client = tcpClient;
}
/* -------------------------------------------------------------------------- */

/* -------------------------------------------------------------------------- */
lwipClient::~lwipClient()
{
stop();

if(!_provided_tcp_client) {
mem_free(_tcp_client);
}
}
/* -------------------------------------------------------------------------- */

Expand Down
3 changes: 3 additions & 0 deletions libraries/lwIpWrapper/src/lwipClient.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ class lwipClient : public Client {
lwipClient();
lwipClient(uint8_t sock);
lwipClient(struct tcp_struct* tcpClient);
virtual ~lwipClient();

uint8_t status();
virtual int connect(IPAddress ip, uint16_t port);
Expand Down Expand Up @@ -68,6 +69,8 @@ class lwipClient : public Client {
private:
struct tcp_struct* _tcp_client;
uint16_t _timeout = 10000;

const bool _provided_tcp_client;
};

#endif