Skip to content

Add a way to read the attached pin no for servos #5391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rkost
Copy link

@rkost rkost commented Sep 20, 2016

Sometimes it is nice to get this information so why not have a function for this?

@facchinm facchinm added Library: Servo The Servo Arduino library feature request A request to make an enhancement (not a bug fix) labels Sep 21, 2016
@matthijskooijman
Copy link
Collaborator

This seems like a reasonable change to me. However, should the isActive flag not be checked as well? Now, I believe you get 0 before attaching, and the previous pin value after detaching, which might not be entirely consistent. Also, if this is merged, the new function should be documented. Care to write some documentation that be pasted into the reference right away?

@rkost
Copy link
Author

rkost commented Nov 24, 2016

You are right. The isActive flag should be checked. Documentation may be written by me in the next week. Where do I contribute the docs?

@matthijskooijman
Copy link
Collaborator

In a comment here is fine, they can be formatted and copied to the site by the Arduino devs.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request A request to make an enhancement (not a bug fix) Library: Servo The Servo Arduino library
4 participants