Skip to content

Keep Serial Monitor open during upload #2809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Keep Serial Monitor open during upload #2809

wants to merge 5 commits into from

Conversation

holgerlembke
Copy link

Keep Serial Monitor open during upload and don't break existing functions. I became aware that there is another solution after I did my implementation. So perhaps it is obsolete...

First try to work with Github, I need a nanny... :-)
@holgerlembke
Keep Serial Monitor open during upload
87400d9 
Keep Serial Monitor open during upload and don't break existing
functions.
@matthijskooijman
Copy link
Collaborator

There have been a few versions of solutions for this problem. The "accepted" solution so far is to disable the serial monitor during uploads, without closing the window. This is implemented by #2742. If you want to help out, you could perhaps test that code and report your findings?

Still, thanks for your contribution! Hopefully more to come?

If you think your PR adds something to #2742, please tell us what. Otherwise, it is probably better to close this PR?
@holgerlembke
Copy link
Author

As far as I see, there are some notes that #2742 does not work on all platforms.

Perhaps this solution is more compatible...
@PaulStoffregen
Copy link
Contributor

@ArduinoBot build this please
@holgerlembke
Send Board Reset from Serial Monitor
4532618 
This  introduces two new features:

++ a reset button to the serial monitor. So the board can be reset by a
simple button press

++ the "reset board on serial monitor open" has been removed. I think
that removed "feature" was a great annoyance: imagine the Arduino is
controlling some device. And you forgot to open the monitor. Open it
later, Reset, Not nice.
@holgerlembke
Copy link
Author

Hmm. Sorry for any confusion, but apparently I managed to add another change to this pull request. I intended to create two different pulls, on for each commit, but I failed. And I fear to create more chaos if I remove the second commit now.
@ffissore
Copy link
Contributor

@ArduinoBot build this please
@ffissore
Copy link
Contributor

It looks like the bot is sleeping
@ffissore
Copy link
Contributor

@ArduinoBot build this please
@ArduinoBot
Copy link
Contributor

Build failed.
@ffissore
Copy link
Contributor

Ok, it doesn't compile

compile:
    [mkdir] Created dir: /home/jenkins/jenkins/jobs/arduino-pull-request-builder/workspace/app/bin
    [javac] Compiling 65 source files to /home/jenkins/jenkins/jobs/arduino-pull-request-builder/workspace/app/bin
    [javac] warning: [options] bootstrap class path not set in conjunction with -source 1.6
    [javac] /home/jenkins/jenkins/jobs/arduino-pull-request-builder/workspace/app/src/processing/app/NetworkMonitor.java:25: error: NetworkMonitor is not abstract and does not override abstract method closeSerial() in AbstractMonitor
    [javac] public class NetworkMonitor extends AbstractMonitor implements MessageConsumer {
    [javac]        ^
    [javac] Note: Some input files use unchecked or unsafe operations.
    [javac] Note: Recompile with -Xlint:unchecked for details.
    [javac] 1 error
    [javac] 1 warning
@holgerlembke
Copy link
Author

Mine here does.

I can add

@OverRide
public void openSerial() throws Exception {}

@OverRide
public void closeSerial() throws Exception {}

into networkmonitor.java

Perhaps it makes someone happy.
@holgerlembke
Change to keep the Arduinobot compiler happy
16adf82 
Mine compiles without it just fine. But...
@holgerlembke
Copy link
Author

@ArduinoBot build this please
@ffissore
Copy link
Contributor

@holgerlembke I've tried it locally and fails the same way. Your commit holgerlembke/Arduino@16adf82 is about one blank line added
@holgerlembke
Revert "Change to keep the Arduinobot compiler happy"
f598ae2 
This reverts commit 16adf82.
@holgerlembke
Change to keep the Arduinobot compiler happy
383e812 
Second try, commited the wrong file.

I still don't understand why it compiles on Windows her without those
lines. I'm synced, the file is compiled (i checked that) and everything,
so it should.
@holgerlembke
Copy link
Author

@ArduinoBot build this please
@holgerlembke
Copy link
Author

@ArduinoBot build this please.
@ffissore
Copy link
Contributor

@ArduinoBot build this please
@ArduinoBot
Copy link
Contributor

Build successful. Please test this code using one of the following:
http://arduino.cc/download.php?f=/javaide/pull_requests/arduino-PR-2809-BUILD-236-linux32.tar.xz
http://arduino.cc/download.php?f=/javaide/pull_requests/arduino-PR-2809-BUILD-236-linux64.tar.xz
http://arduino.cc/download.php?f=/javaide/pull_requests/arduino-PR-2809-BUILD-236-windows.zip
http://arduino.cc/download.php?f=/javaide/pull_requests/arduino-PR-2809-BUILD-236-macosx.zip
@holgerlembke holgerlembke mentioned this pull request Apr 14, 2015
Closed
@cmaglie cmaglie added feature request A request to make an enhancement (not a bug fix) Component: IDE user interface The Arduino IDE's user interface labels Apr 15, 2015
@per1234 per1234 added the Component: IDE Serial monitor Tools > Serial Monitor label Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: IDE Serial monitor Tools > Serial Monitor Component: IDE user interface The Arduino IDE's user interface feature request A request to make an enhancement (not a bug fix)
7 participants
@holgerlembke @matthijskooijman @PaulStoffregen @ffissore @ArduinoBot @cmaglie @per1234