Skip to content

feat(json-schema): mutualize json schema between formats #6960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 21, 2025
Merged

feat(json-schema): mutualize json schema between formats #6960

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e04892d
test: openapi fixes
soyuka May 12, 2025
b0b3fe4
cs(metadata): nullable operator
soyuka May 12, 2025
9f29a3c
fix(json-schema): share invariable sub-schemas
soyuka May 13, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cs(metadata): nullable operator
  • Loading branch information
@soyuka
soyuka committed May 15, 2025
commit b0b3fe40f19c5957ec9fe2fc580a7f01d1492439
4 changes: 2 additions & 2 deletions src/Metadata/Property/Factory/SerializerPropertyMetadataFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@ private function transformReadWrite(ApiProperty $propertyMetadata, string $resou
}

$serializerAttributeMetadata = $this->getSerializerAttributeMetadata($resourceClass, $propertyName);
$groups = $serializerAttributeMetadata ? $serializerAttributeMetadata->getGroups() : [];
$ignored = $serializerAttributeMetadata && $serializerAttributeMetadata->isIgnored();
$groups = $serializerAttributeMetadata?->getGroups() ?? [];
$ignored = $serializerAttributeMetadata?->isIgnored() ?? false;

if (false !== $propertyMetadata->isReadable()) {
$propertyMetadata = $propertyMetadata->withReadable(!$ignored && (null === $normalizationGroups || array_intersect($normalizationGroups, $groups)));
Expand Down