-
Notifications
You must be signed in to change notification settings - Fork 1.4k
DOC: Add Security section to the documentation. #17583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
* Each Apache project should have its own security guide. * Security section is added to the NuttX documentation. * Information about reported and fixed CVEs. * Information and hints on how to report and handle security issues in accordance with The Apache Security Team [1] and Committers Guide [2]. * Information on what is and is not considered a vulnerability. [1] https://www.apache.org/security [2] https://www.apache.org/security/committers.html Signed-off-by: Tomasz 'CeDeROM' CEDRO <tomek@cedro.info>
linguini1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I think the commit message should start withs docs/security: to be consistent with other messages.
| NuttX CVEs | ||
| ========== | ||
|
|
||
| TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use the .. todo:: directive here to indicate to contributors what is left to be done in the hopes that they might add some information.
| Vulnerabilities and Exposures) identifiers. List of known, responsibly | ||
| disclosed, and fixed vulnerabilities are publicly available online at | ||
| `CVE.ORG <https://www.cve.org/CVERecord/SearchResults?query=nuttx>`_. | ||
| Offline bundled version is located at the bottom of this page in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other websites have it so we can have it too.. or mark as todo and add in a free moment :-)
| but most importanly fix patches are more than welcome.** | ||
|
|
||
| 5. There are problems that we are well aware of, and have been reported | ||
| to us many times, but we do not class as a security vulnerability, see |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not classify
| Below is an extract of the most important information: | ||
|
|
||
| 1. Please report potential security vulnerabilities over email to | ||
| security@apache.org and security@nuttx.apache.org **before disclosing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't have a security@nuttx.apache.org list yet, right? You can request one (see https://apache.org/security/committers.html#lists), but I'm not sure it's necessary for nuttx.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope we do not have one yet, i asked pmc if we want one, it seems automated with security@apache.. will probably make a vote or retry the internal discussion, thanks! :-)
| any reference to the security nature of the commit. | ||
|
|
||
|
|
||
| Below is an extract of the most important information: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you seem to repeat most of the workflow at https://apache.org/security/committers.html . I'm not opposed to it, but it doesn't seem necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, just to have all-in-one place hints for reporters and handlers and part of the documentation :-)
| Not security vulnerabilities | ||
| ============================ | ||
|
|
||
| Apache NuttX RTOS is highly portable to over 15 different CPU architectures, | ||
| including microcontrollers with as tiny memory resources as single kilobytes | ||
| of RAM/Flash memory. Putting additional checks outside a generic nature would | ||
| dramatically impact final firmware performance and size. | ||
| **Function parameters and incoming data validation rests on the | ||
| custom application/firmware developer.** | ||
|
|
||
| Special care should be taken when handling: | ||
|
|
||
| * syscalls. | ||
| * pointers (always set to NULL before and after use). | ||
| * structures (always initialize with ``{0}`` before use). | ||
| * user controllable data (type and size). | ||
| * network data. | ||
| * dynamically allocated buffers. | ||
|
|
||
| .. note:: | ||
| If you find a generic problem in existing code base that | ||
| may impact Confidentiality, Integrity, or Availability (i.e. information | ||
| leak, denial of service, remote code execution) and is not your own custom | ||
| application specific, please send us a security report. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
hartmannathan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one minor typo; otherwise, thank you for improving NuttX Documentation!
| urgent cases special patch releases may be created to address the issue. | ||
| In order to keep this process smooth please provide us with as much | ||
| details as possible. **Reproducible examples, proof-of-concept code, | ||
| but most importanly fix patches are more than welcome.** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| but most importanly fix patches are more than welcome.** | |
| but most importantly fix patches are more than welcome.** |
Summary
[1] https://www.apache.org/security
[2] https://www.apache.org/security/committers.html
Impact
Testing