fix(stream): use correct end_id in XPENDING command #3281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i18nsite
force-pushed
the
split_changes
branch
from
f281116 to
e935785
Compare
PragmaTwice
reviewed
Dec 1, 2025
PragmaTwice
changed the title
i18nsite
force-pushed
the
split_changes
branch
from
c6d5301 to
62f3321
Compare
PragmaTwice
reviewed
Dec 1, 2025
i18nsite
force-pushed
the
split_changes
branch
from
62f3321 to
b65795d
Compare
The XPENDING command was incorrectly using the start_id instead of the end_id when parsing the range arguments. This caused incorrect filtering of pending entries when a range was specified. This commit fixes the issue by passing the correct end_id to the ParseStreamEntryID function.
i18nsite
force-pushed
the
split_changes
branch
from
b65795d to
faf1267
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
English / 中文
English
Description
This PR fixes a bug in the
XPENDINGcommand where theend_idwas incorrectly parsed using thestart_id. This issue caused incorrect results when querying pending entries with a specific range.Fixes #3276
中文
描述
此 PR 修复了
XPENDING命令中的一个 bug，该 bug 导致在解析end_id时错误地使用了start_id。这个问题会导致在指定范围查询待处理条目时结果不正确。修复 #3276